Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 20, 2024

CNCT-2408


PR-Codex overview

This PR updates the documentation comments for several components in the NFT module to include the @beta tag, indicating that these components are in beta status.

Detailed summary

  • Updated documentation comments in name.tsx, provider.tsx, and media.tsx to include @beta alongside @nft.
  • The NFTMediaProps type definition in media.tsx now includes the @beta tag in its documentation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Nov 20, 2024

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: e97f288

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:46am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:46am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:46am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:46am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 325 ms (+479.24% 🔺) 1.3 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 530 ms (+115.39% 🔺) 2.7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 120 ms (+498.73% 🔺) 232 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 49 ms (+2086.31% 🔺) 59 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 168 ms (+1194.64% 🔺) 536 ms

@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.81%. Comparing base (0e5d120) to head (e97f288).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5468   +/-   ##
=======================================
  Coverage   43.81%   43.81%           
=======================================
  Files        1069     1069           
  Lines       55726    55726           
  Branches     3882     3881    -1     
=======================================
  Hits        24415    24415           
  Misses      30628    30628           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f368793
packages 38.50% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...s/thirdweb/src/react/web/ui/prebuilt/NFT/media.tsx 57.57% <ø> (ø)
...es/thirdweb/src/react/web/ui/prebuilt/NFT/name.tsx 71.42% <ø> (ø)
...hirdweb/src/react/web/ui/prebuilt/NFT/provider.tsx 72.22% <ø> (ø)
---- 🚨 Try these New Features:

Copy link
Member

jnsdls commented Nov 21, 2024

Merge activity

  • Nov 20, 8:57 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 20, 10:04 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 21, 12:27 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 21, 2024
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Nov 21, 2024
@gregfromstl
Copy link
Contributor Author

Included in a separate PR, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants